fix: Do not let exceptions in before_breadcrumb bubble up - #7133
Merged
Conversation
Contributor
Codecov Results 📊✅ 99265 passed | ⏭️ 6479 skipped | Total: 105744 | Pass Rate: 93.87% | Execution Time: 355m 11s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2500 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.99% 90.02% +0.03%
==========================================
Files 193 193 —
Lines 24974 25048 +74
Branches 9008 9036 +28
==========================================
+ Hits 22473 22548 +75
- Misses 2501 2500 -1
- Partials 1437 1442 +5Generated by Codecov Action |
sentrivana
marked this pull request as ready for review
August 7, 2026 09:39
sentrivana
force-pushed
the
ivana/before-breadcrumb-guard
branch
from
August 7, 2026 09:42
1edae07 to
25d07de
Compare
sentrivana
changed the base branch from
ivana/move-http-client-breadcrumbs-1
to
master
August 7, 2026 09:42
alexander-alderman-webb
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's a problem in
before_breadcrumb, it could take down the whole app.